Cleaned up the codebase a bit to help aleviate #16

globocom / gcloud-utils

Global package for Cloud Management in Python

https://gcloud-utils.readthedocs.io/en/latest/

Apache License 2.0

16 stars 23 forks source link

Cleaned up the codebase a bit to help aleviate #16 #21

Closed dekomote closed 4 years ago

dekomote commented 4 years ago

Cleaned up the codebase, pylint now up several points.

I'd strongly suggest for you guys to install pre-commit hooks including black, pylint and trimming whitespace. Also, turn on trimming whitespaces in your editors, you will save a ton of hassle.

It wouldn't hurt having a sane .pylint as most of the warnings you'll now get are things that companies usually skip.

alexandreyy commented 4 years ago

Could you suggest a configuration for our pylint?

dekomote commented 4 years ago

Yes. I'll make a PR to master with pylint, as well as isort, and black and everything.

alexandreyy commented 4 years ago

@dekomote , could you solve these conflicts? after that, we can proceed with the MR.

dekomote commented 4 years ago

@alexandreyy fixed up the conflicts. Please do another review and then merge away.

alexandreyy commented 4 years ago

Shipped. Thanks, @dekomote