search

globocom / gcloud-utils

Global package for Cloud Management in Python
https://gcloud-utils.readthedocs.io/en/latest/
Apache License 2.0
16 stars 23 forks source link

Update dependencies, fix some lintings and warnings #22

Closed eulercb closed 4 years ago

eulercb commented 4 years ago

Updates Google dependencies.

Fix #14, #20 and partially #16 (protobuffer warnings https://github.com/protocolbuffers/protobuf/issues/5865)

eulercb commented 4 years ago

@alexandreyy was the version increment correct? I'm not sure if this should be PATCH or a MINOR version increment.

alexandreyy commented 4 years ago

It should be a minor increment. Just make sure nothing gets broken with this update.

eulercb commented 4 years ago

@alexandreyy some pylint warnings involved a larger refactor that I think should be made on a new PR.

alexandreyy commented 4 years ago

Ok. We already have an issue opened to fix warnings.

eulercb commented 4 years ago

Updated description to link to all issues related. @alexandreyy is there something else you suggest me to do about this PR?

alexandreyy commented 4 years ago

Updated description to link to all issues related. @alexandreyy is there something else you suggest me to do about this PR?

No. Everything seems to be OK. We can ship it. Thanks, @eulercamposbarros !