Closed eulercb closed 4 years ago
@alexandreyy was the version increment correct? I'm not sure if this should be PATCH or a MINOR version increment.
It should be a minor increment. Just make sure nothing gets broken with this update.
@alexandreyy some pylint warnings involved a larger refactor that I think should be made on a new PR.
Ok. We already have an issue opened to fix warnings.
Updated description to link to all issues related. @alexandreyy is there something else you suggest me to do about this PR?
Updated description to link to all issues related. @alexandreyy is there something else you suggest me to do about this PR?
No. Everything seems to be OK. We can ship it. Thanks, @eulercamposbarros !
Updates Google dependencies.
Fix #14, #20 and partially #16 (protobuffer warnings https://github.com/protocolbuffers/protobuf/issues/5865)