search

globocom / huskyCI

Performing security tests inside your CI
https://huskyci.opensource.globo.com
BSD 3-Clause "New" or "Revised" License
572 stars 137 forks source link

Typo in .huskyci example #494

Closed s1mahoeg closed 4 years ago

s1mahoeg commented 4 years ago

The docu for an .huskyci example file contains a typo. It should be # Safety igNOre instead of # Safety igONre

https://huskyci.opensource.globo.com/docs/guides/handling-false-positives#huskyci:

[huskyCI-Ignore]

# Bandit ignore:
tests/

# Safety igonre:  <-- typo
vendor/

# Gosec ignore:
api/server.go
rafaveira3 commented 4 years ago

Hello, @s1mahoeg! Thanks for the feedback! Good catch. Would you like to send us this PR or prefer that we do so? 🙃

s1mahoeg commented 4 years ago

Hello @rafaveira3, Is the docu also open source? I couldn't find the corresponding repository. That's why I didn't send any PR.

rafaveira3 commented 4 years ago

Great point, @s1mahoeg! We haven't open sourced our documentation page yet! 😅 I will try to do this soon, with this typo fix done! Thanks a lot for the feedback 🙃

rafaveira3 commented 4 years ago

hey, @s1mahoeg! We have fixed and deployed it. Sorry for the long delay. We haven't been able to open source it yet as we have some infra related code in it. Thanks once again for the report :)

s1mahoeg commented 4 years ago

hi @rafaveira3, no problem. Thank you :)