search

globocom / m3u8

Python m3u8 Parser for HTTP Live Streaming (HLS) Transmissions
Other
2.03k stars 471 forks source link

Ruff cleanup #337

Closed daveisfera closed 10 months ago

daveisfera commented 11 months ago

Cleans up the issues found by ruff after the changes from #336

mauricioabreu commented 11 months ago

That's HUGE! 👏🏼

Thank you!

mauricioabreu commented 11 months ago

@daveisfera could you solve these conflicts? I think they were raised from your previous contributions

daveisfera commented 11 months ago

@daveisfera could you solve these conflicts? I think they were raised from your previous contributions

Done

daveisfera commented 11 months ago

I added an action to run ruff on pushes and pull requests

daveisfera commented 10 months ago

Could this PR and the others I submitted (#334 #335 #339) be merged? I'd love to get a release with these improvements out there (especially performance improvement that was already merged #336)

mauricioabreu commented 10 months ago

@daveisfera yes. Could you rebase your PR against master? Then I will merge it.

daveisfera commented 10 months ago

Rebased and could #345 be merged as well so timespec can be used at the top level? Thanks for all of your work on this project!

mauricioabreu commented 10 months ago

@daveisfera thank you for all your recent contributions. It means a lot.

daveisfera commented 10 months ago

@daveisfera thank you for all your recent contributions. It means a lot.

Added one more to keep formatting consistent with ruff: https://github.com/globocom/m3u8/pull/346