search

globocom / react-native-draftjs-render

React Native render for draft.js model
MIT License
390 stars 62 forks source link

Call customBlockHandler before to be able to override supported styles #29

Closed simontreny closed 6 years ago

simontreny commented 6 years ago

I would like to customize the way some blocks are rendered (especially, headings and blockquotes). Right now, "header-" are necessarily rendered as a DraftJsText and "blockquote-" have a fixed layout with a container view, a DraftJsText, an icon before and an icon after. Unfortunately, this does not match the design I'd like to implement.

This pull-request allows to implement customBlockHandler to override the rendering of any styles, allowing further customization of their layout.

raphaelpor commented 6 years ago

Hi @simontreny!

Nice job! But, could you fix the tests before we accept your PR? It'd be good if you write some documentation for this too. 😉

Canedo commented 6 years ago

Hey @simontreny .

I updated all devDependencies and fixed some CI and automatization on the project. You can ignore the appVeyor build failed, for example.

But with your PR there is a test failing. Can you provided us a fix to that? We will wait your response!