search

globocom / react-native-ua

React Native module for Urban Airship
MIT License
37 stars 33 forks source link

Use latest gms play services #16

Closed eosterberg closed 8 years ago

arthursz commented 8 years ago

Hi @eosterberg,

unfortunately you can't pump gms play service location version that way because it will generate a conflict with the version that is inside Urban Airship SDK. According to the setup section of Urban Airship docs, you will have to pump the Urban Airship SDK version to 7.2.+ and use the same gms play service location version that Urban use 9.0.2. The gradle will look like this:

... compile 'com.urbanairship.android:urbanairship-sdk:7.2.+' compile 'com.android.support:cardview-v7:23.4.0' compile 'com.google.android.gms:play-services-location:9.0.2'

Can you made this changes and update your PR? Thanks!

rlepinski commented 8 years ago

@arthursz If you specify a newer google play services, it should force UA to use a newer version, but you need to also specify the gcm module. However + is normally not the way to go. There are serious issues with some older GPS versions.

We use this in the cordova plugin:

compile 'com.google.android.gms:play-services-location:[9.0.2,10['
compile 'com.google.android.gms:play-services-gcm:[9.0.2,10['

Which allows any version 9.x version newer than 9.0.2.

arthursz commented 8 years ago

Hi @eosterberg,

this improvement was implemented on another PR.

Thanks!