search

globocom / react-native-ua

React Native module for Urban Airship
MIT License
37 stars 33 forks source link

added get_channel_id method #44

Closed sumzer closed 7 years ago

sumzer commented 7 years ago

We are using this repo for our project and we need method getChannelId wich is provided by UrbanAirship SDk library. http://docs.urbanairship.com/platform/android.html#retrieving-your-channel-id can you check it and approve it.

Thanks in advance Best regards Sumi

rlepinski commented 7 years ago

Could you update the README with the added method?

Other than the code spacing issue, everything looks good to me.

sumzer commented 7 years ago

Hi, I've pushed changes, please check it. Best regards Sumi

rlepinski commented 7 years ago

This looks great to me. I do not have the ability to merge commits. Paging @evandroeisinger

evandroeisinger commented 7 years ago

@rlepinski you didn't have? We already gave you write permissions; Could you check, please?

rlepinski commented 7 years ago

@evandroeisinger I had an invite in my inbox from a few weeks ago. Thanks :)

evandroeisinger commented 7 years ago

@rlepinski just to let you know that I already added you to the npm project. Now you are able to deploy new versions.