Include Burn Rate Option

globocom / slo-generator

Easy setup a service level objective using prometheus

MIT License

129 stars 18 forks source link

Include Burn Rate Option #13

Closed rodrigo-brito closed 4 years ago

rodrigo-brito commented 4 years ago

I notice that Burn Rate Alert has the same structure of Simple Alert but with a custom multiplier. Therefore, I only included a multiplier factor in AlertOptions. If the multiplier is not given, a default multiplier equals to one is used in place.

What do you think about it? A separated alert is better or this is a good option? I tried to avoid code duplication.

Ref https://github.com/globocom/slo-generator/issues/3

wpjunior commented 4 years ago

nice job @rodrigo-brito could you document this in README.md ?

rodrigo-brito commented 4 years ago

@wpjunior done!

wpjunior commented 4 years ago

Thanks so very much @rodrigo-brito