globocom / slo-generator

Easy setup a service level objective using prometheus
MIT License
129 stars 18 forks source link

Maintaining consistency in receiver type #2

Closed viniciusbds closed 4 years ago

viniciusbds commented 4 years ago

If some of the methods of the type must have pointer receivers, the rest should too, so the method set is consistent regardless of how the type is used.

https://golang.org/doc/faq#methods_on_values_or_pointers

wpjunior commented 4 years ago

Thanks @viniciusbds <3