search

globocom / slo-generator

Easy setup a service level objective using prometheus
MIT License
129 stars 18 forks source link

Support other alerting methods #3

Closed wpjunior closed 4 years ago

wpjunior commented 4 years ago

Other methods are described in SRE workbook chapter: alerting on SLO

rodrigo-brito commented 4 years ago

Hi @wpjunior, I will try to include Burn Rate Alert. I saw an interface AlertMethod to be implemented in method folder, it's the right place? How can I test it?

wpjunior commented 4 years ago

Hi @rodrigo-brito yeah, there is a right place, the tests nowadays just uses the generated promql string to assert the result, this alert-method is the last one to full implement all alert methods of SRE.