search

globophobe / django-semantic-admin

✨ Django Semantic UI admin theme
https://semantic-admin.com
MIT License
142 stars 9 forks source link

Input type not defined on fields #81

Closed captain828 closed 8 months ago

captain828 commented 8 months ago

It seems the input type isn't being set for most field types. This partially breaks validation errors as inputs don't get the red background.

Only the "search" type has it (used in many-to-many rels).

globophobe commented 8 months ago

Thanks for reporting! I could confirm an issue with server side validation with required text fields in the https://semantic-admin.com demo.

Is your issue also related to server side validation, or perhaps real time client side validation?

validation

globophobe commented 8 months ago

Maybe related to noNativeValidation option in as of yet unreleased FomanticUi 2.9.4 https://github.com/globophobe/django-semantic-admin/issues/63#issuecomment-1873049656

captain828 commented 8 months ago

Server-side validation.

I looked at the code but don't know where the tags for the inputs are created as it seems that is the culprit.

globophobe commented 8 months ago

I believe the issue fixed in https://github.com/globophobe/django-semantic-admin/pull/82 The demo was updated with that branch, and if there are no problems I'll merge and release tomorrow or the day after

text-input

globophobe commented 8 months ago

Version 0.4.1 was released. Please let me know if this issue is resolved

captain828 commented 8 months ago

I can confirm it's solved, thanks!