search

globus-gladier / gladier

An SDK for rapidly developing Globus Flows while leveraging Globus Compute
Apache License 2.0
9 stars 3 forks source link

Pydantic based models for States for a flow #253

Closed jimPruyne closed 1 year ago

jimPruyne commented 1 year ago

This provides a class-based method for defining flow states and composing and chaining them together as desired. The pydantic based classes retain compatibility with the Gladier Tool model, so a GladierBaseClient can, for example, use these classes instead of (and probably in addition to though that should probably be discouraged) instances of GladierBaseTool.

NickolausDS commented 1 year ago

@jimPruyne A lot of changes to existing modules are formatting changes, and during review I'm seeing some functional changes mixed in. Mind if we merge #256 ahead of this one? That should remove all the formatting changes here for readability.

NickolausDS commented 1 year ago

I think we covered all the major things I wanted to revisit and on another quick review I don't see any other changes before merge. I'm going to go through once more to add documentation and try for #261 to work out any other significant things that are missing, but I think we can probably merge this and iterate on any other changes we want to add as part of the next version.

NickolausDS commented 1 year ago

Approved and merged. Have a good weekend!