search

globus-gladier / gladier

An SDK for rapidly developing Globus Flows while leveraging Globus Compute
Apache License 2.0
9 stars 3 forks source link

Composite State Updates #278

Open jimPruyne opened 1 year ago

jimPruyne commented 1 year ago

This adds some updates to how the composite states are handled. It changes the protocol for generating the flow definition. It supports setting a prefix on a composite state which is pre-pended to each state generated. To do this, the get_flow_definition implementation calls out to a separate method which generates the composite flow at the state model level rather than at the flow definition dict level.

This also specs the method of setting next on a composite state. There's more than can probably be done in this space, but it does seem to provide the minimum necessary functionality.

Also includes an example state for using Choice to optionally skip a state. This maybe shouldn't be in this package (e.g. in gladier-tools instead), but it does provide an example (and testable) of the use of BaseCompositeState within the main gladier package which probably makes sense to have in the main gladier package.

NickolausDS commented 1 year ago

@jimPruyne Did you have more updates you wanted to add here?

jimPruyne commented 1 year ago

@NickolausDS Just coming back to this. I'll take a look at your comments and see what updates we can make to push this forward. Thanks for the feedback.