globus / globus-compute

Globus Compute: High Performance Function Serving for Science

https://www.globus.org/compute

Apache License 2.0

148 stars 47 forks source link

Revert PR 256 #313

Closed BenGalewsky closed 3 years ago

BenGalewsky commented 3 years ago

Problem

PR #256 - removed the top level __init__.py files in the funcx_sdk and funcx_endpoint directories. It turns out this is a bad idea

WardLT commented 3 years ago

What was the problem with removing the __init__.pys?

yadudoc commented 3 years ago

funcx and funcx_endpoint are no longer namespace packages but complete packages sharing the same repo. While namespace packages shouldn't have an __init__.py file in the root, regular packages need one.

WardLT commented 3 years ago

Interesting! I did not know about namespace packages vs regular :D