search

globus / globus-compute

Globus Compute: High Performance Function Serving for Science
https://www.globus.org/compute
Apache License 2.0
148 stars 47 forks source link

Incorrectly used `MalformedResponse` in `client.py` #96

Closed rohankumar42 closed 4 years ago

rohankumar42 commented 4 years ago

funcx/sdk/client.py doesn't correctly use MalformedResponse. It is neither imported from funcx/errors.py nor is it called correctly. This leads to an unhelpful NameError being thrown when an unexpected HTTP response is received (e.g., a GlobusAuth error).

https://github.com/funcx-faas/funcX/blob/281d2c21715d1efe597145295ceeed06c461a3cf/funcx/sdk/client.py#L181

rohankumar42 commented 4 years ago

Related issue: #88

annawoodard commented 4 years ago

Fixed in #107