glocq
commented
3 years ago Welp. I have an issue, but I think it dates back to your earlier pull request. We should have tested seriously. The issue is: I tried some code with a parameter, but moving the slider doesn't change the parameter.
I tried to see what commit introduced the issue, it seems to be the "general code review", but it's hard to be sure because of all the merges that happen afterwards (I'm still trying to get to grips with merges in git).
I think I will go back to before your code review, and try to introduce the changes one by one with appropriate testing at each step.
Three remarks:
- Please pull the most recent changes before changing stuff, it saves some headaches.
- We should test the software appropriately before pushing anything (we're both guilty of not testing enough)
- I will make a branch for development. I thought the project was confidential enough that it didn't need that, but there's already an issue of someone unsuccessful in trying to run the software.
Heres my attempt to fix that bug :)... lets see how it goes :)... I removed the smart pointer and used nullptr instead of argv... tested it and was working on osx... not extensive testing though