search

gloebit / opensim-moneymodule-gloebit

OpenSim addon module integrating with the Gloebit digital currency service
GNU Lesser General Public License v3.0
8 stars 12 forks source link

Encapsulated BuildParamStrings and OSDMap usage in helpers #3

Closed colosi closed 9 years ago

colosi commented 9 years ago

Created BuildURLEncodedParamString helper Converted BuildWebRequest to use Dictionary instead of OSDMap Converted URL & created JSON string encoder helpers to use Dictionaries Interfaces are now using standard C# Dictionaries. OSDMap is encapsulated in helpers. Two issues with switching from OSDMap to Dictionaries were having to convert values to strings, and not being able to easily log a Dictionary.

bradkittenbrink commented 9 years ago

Let's not merge this for now as I realized that we need to keep using OSDMap to make sure params get submitted to the apis as the correct types (instead of coercing them all to strings). How about we update this PR so just the first commit is in it. I can show you how.

bradkittenbrink commented 9 years ago

assign it back to me when we've fixed it up

colosi commented 9 years ago

From Command Line, removed second commit. Status is now single commit of single file (from 2 commits). Helper now uses OSDMap again and OSDMap is passed in interface.

bradkittenbrink commented 9 years ago

LGTM, go ahead and merge when you're ready.