search

gloebit / opensim-moneymodule-gloebit

OpenSim addon module integrating with the Gloebit digital currency service
GNU Lesser General Public License v3.0
8 stars 12 forks source link

Fixed bug where scripted object paying an offline user caused a crash… #59

Closed colosi closed 7 years ago

colosi commented 7 years ago

… due to dereferencing null part.

We were assuming the payee was online and the part was in the same scene. When this assumption failed, our part was null. When that happened, we crashed when building the transaciton and trying to get the part.name and part.description.

Now we cycle through all of our scenes on the sim until we find the one with the part.

As a larger OpenSim design note, any SharedRegionModule functions such as this should include the scene in the arguments passed in to the event. Since it does not, we have to do extra work to retrieve information thrown away just before calling our function.

colosi commented 7 years ago

I need to get this fix out over the weekend. I'll ask Brad to review when he returns on Monday, but I'm pulling this in to get the fix out to our partner.

bradkittenbrink commented 7 years ago

Looks good. No objections