search

gloebit / opensim-moneymodule-gloebit

OpenSim addon module integrating with the Gloebit digital currency service
GNU Lesser General Public License v3.0
8 stars 12 forks source link

Compiler warning CS0659 #83

Closed Tampa closed 4 years ago

Tampa commented 4 years ago

GloebitSubscription.cs(35,18): warning CS0659: 'GloebitSubscription' overrides Object.Equals(object o) but does not override Object.GetHashCode()

Whether the override is needed or not it produces a compiler warning which should be avoided to sanitize the compiler output making actual problems easier to see.

colosi commented 4 years ago

Because the DB truncates the timestamp, I had to change the Object.Equals to also truncate, otherwise the object would fail an equality test after serializing to and back from the DB. I did not update the hashcode to truncate that. Adding an override for GetHashCode should fix this warning.

Tampa commented 4 years ago

In my current pull request I simply silenced the warning, if an override is needed to ensure functionality then adding one would make sense, but seeing as it is not there I guess it is not needed so silencing the warning is fine.

colosi commented 4 years ago

fixed by #87