gloewing / photometry_FLMM

Code for Functional Mixed Models for Fiber Photometry
7 stars 0 forks source link

Feature request: Parallelisation for Windows #1

Closed KathaSchmack closed 1 month ago

KathaSchmack commented 1 month ago

It seems that "fui" cannot be run with parallel = TRUE on Windows. It produces the following error: Error in mclapply(argvals, unimm, mc.cores = num_cores) : 'mc.cores' > 1 is not supported on Windows

gloewing commented 1 month ago

Did you first install the new fastFMM version? That error makes sense for the old fui() version but on the new one, Windows should use a different parallelization function.

On Fri, Sep 27, 2024 at 8:18 AM Katharina Schmack @.***> wrote:

It seems that "fui" cannot be run with parallel = TRUE on Windows. It produces the following error: Error in mclapply(argvals, unimm, mc.cores = num_cores) : 'mc.cores' > 1 is not supported on Windows

— Reply to this email directly, view it on GitHub https://github.com/gloewing/photometry_FLMM/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVLMQOJSXU3S7OAPCP4NRLZYVEHTAVCNFSM6AAAAABO7BN26WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TENZYGI2DENI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

KathaSchmack commented 1 month ago

Thank you! This happens with the fastFMM version 0.2.0 which got installed when I ran install.packages("fastFMM", dependencies = TRUE).

gloewing commented 1 month ago

That makes sense: I don't think the new fastFMM version (with PC parallelization capability) has been added to CRAN yet (hopefully it will be in 1-2 weeks). But you can still download the new fastFMM version (with PC parallelization capability) with the following code:

install.packages('devtools') # not necessary if you already have devtools installed devtools::install_github('gloewing/fastFMM')

Let me know if parallelization works after you install the new version.

On Fri, Sep 27, 2024 at 10:31 AM Katharina Schmack @.***> wrote:

Thank you! This happens with fastFMM version 4.4.1 which got installed when I ran install.packages("fastFMM", dependencies = TRUE).

— Reply to this email directly, view it on GitHub https://github.com/gloewing/photometry_FLMM/issues/1#issuecomment-2379421821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVLMQNY47PIJ3LK2NZ6OE3ZYVT4PAVCNFSM6AAAAABO7BN26WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGQZDCOBSGE . You are receiving this because you commented.Message ID: @.***>

KathaSchmack commented 1 month ago

Fantastic, that worked, thank you!