Closed Kyrluckechuck closed 6 months ago
any chance of updating this pr to the latest version?
any chance of updating this pr to the latest version?
@NeonLightning I don't believe the repo author intends to merge this PR since it's been left for so long, but I went and updated it based on the latest upstream main
here -- a few of the tweaks I improved were no longer necessary since a few things were improved in the base PR, but the rest of the tweaks were re-added!
I only did some quick tests using a couple of albums and playlists I had not downloaded, but all seemed to work as expected. Let me know if you have any issues!
😰
😰
@glomatico if you are interested in merging these changes (or have any feedback about them) I'm happy to rebase this on your latest changes again! 🙂
😰
@glomatico if you are interested in merging these changes (or have any feedback about them) I'm happy to rebase this on your latest changes again! 🙂
Well, sorry for ignoring your pull request for so long. I think I'm up only for the Additional Copyright Handling to be pushed for now.
No worries at all! That's completely fair -- I'm actually going to opt to close this out (though feel free to copy in any changes if you like them), since I've decided to kinda completely fork this via https://github.com/Kyrluckechuck/spotify-library-manager! 😄
Description
This PR accounts for a few scenarios that I encountered Spotify throwing while dealing with a playlist of > 2000 songs:
P
license vs aT
license (one of the example songs I had returned that type), so I went the route of simply "ignoring it" and just marking the text as''
** After the last PR was closed by upstream code changes and wasn't explicitly closed as invalid, I figured I should rebase and then re-open it. If there are any issues here, I'm happy to address them, or I can just keep my fork with the various improvements I've made elsewhere if you'd prefer not to!
Notes
This took a couple creative liberties based on me not specifically caring about certain things in how it was parsed and just wanted it to work, so I'm open to suggestions here 😄 (such as updating the max line length to be a "normal" value these days)