Project Feedback

[glomstea]

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

• [x] At least 3 button elements are included in your page
• [x] When each of the buttons are hovered over (mouseenter event) or clicked on (click event), a unique sound effect plays from an audio element (try the .play() method) -- you may use these drum kit sounds, create ones from this sound effects generator, or use any other sounds that won't hurt/irritate the people who listen to them
• [x] Each button is well-labeled, corresponding to the sound it will play
• [x] All audio elements are invisible (no controls attribute), so that they can only be played with the buttons
• [x] All of your JavaScript is in a separate file ending with .js

[stuartpearman]

Hey Grant, good start! A few things I saw:

HTML vs. Javascript events

Re-read criteria 5:

All of your JavaScript is in a separate file ending with .js

So this means instead of using the onclick and 'onmouseenter' attributes, you'll need to use event listeners. This slide from the lesson talks about event listeners.

2-space indentation

In this class, we're using 2-space indentation for all projects. This slide from the lessons talks more about setting up indentation in Atom, as well as why we choose the indentation standards that we do :+1:

Let me know once you've made changes 😎