Project Feedback

[glomstea]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Includes a button that when clicked, will toggle the website between day and night themes
• [x] When a user changes the theme, their choice is remembered in localStorage
• [x] The class on the body element is always up-to-date with the current theme (either day-theme or night-theme) -- you can use document.body.setAttribute('class', 'some-class-name') to set the class on the body
• [x] When the body has the class day-theme, the background of the website is light-colored, with a darker color for the text
• [x] When the body has the class night-theme, the background of the website is a very dark color, with a lighter color for the text
• [x] Somewhere on the page, the user is told how many times they've visited the website (starting with 1 the first time)

[egillespie]

Works great! 💃 I have a couple of suggestions to tighten up the code a bit:

Use if/else when possible

There's a spot where you have two if statements back-to-back that are mutually exclusive:

if (changeVariable === 1) {
  document.body.setAttribute('class', 'dark')
}
if (changeVariable === -1) {
  document.body.setAttribute('class', 'light')
}

You can turn this into an if/else to avoid unnecessary comparisons (and less overall code):

if (changeVariable === 1) {
  document.body.setAttribute('class', 'dark')
} else {
  document.body.setAttribute('class', 'light')
}

Shorter ways to multiply by -1

You have a very explicit multiplication by -1 in your code:

changeVariable = changeVariable * -1

That can be shortened up in two different ways:

changeVariable = -changeVariable
changeVariable *= -1

The first line is a shorter way of multiplying changeVariable by -1. The second line is a short way to multiply a value by a number and reassign the result to itself.

They're all fine, but I thought you may be interested in trying one of them out. (i.e. you don't have to change your multiplication lines if you don't want to)

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🎸

[glomstea]

@egillespie Fixed what you were asking for.

[egillespie]

Very nice! :shipit: