search

glondu / belenios

Verifiable online voting system. This is a mirror of https://gitlab.inria.fr/belenios/belenios
https://www.belenios.org
GNU Affero General Public License v3.0
133 stars 21 forks source link

Small fix: Track an empty tests/tools/data directory #64

Closed mjal closed 1 year ago

mjal commented 1 year ago

Running the tests/tool/demo.sh script fail when the data/ directory doesn't exist. The data/ directory is in .gitignore but an empty directory should exist for the script to succeed.

We could:

  1. Add a .gitignore file in the data/ directory (with git add -f since it is ignored)
  2. Use mkdir -p in the script instead.
  3. Do nothing, experienced user should understand and fix the issue easily

This PR is option 1

glondu commented 1 year ago

The clean target in the surrounding Makefile removes the data directory altogether. The mkdir -p is done in the check target, before calling the shell scripts. Isn't that sufficient? If not, I would rather go with adding -p to the mkdir calls in the scripts...

mjal commented 1 year ago

Oh now I understand... I wasn't using make and called the script directly