gloomyandy / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
256 stars 60 forks source link

[FR] Robin Nano v3 support? #100

Closed KosVas91 closed 2 years ago

KosVas91 commented 3 years ago

Since a while ago, MKS on their GitHub has published an alternative bootloader and RRF 3.2 binaries for MKS Robin Nano V3, can we expect that this board will be supported by TeamGloomy Configurator and more recent RRF versions?

jaysuk commented 3 years ago

not at the moment. It appears they've made other changes than just bootloader but the way they've uploaded the source makes it very difficult to work out what changes those are.

Thanks,

Jay

On Thu, 26 Aug 2021 at 14:59, KosVas91 @.***> wrote:

Since a while ago, MKS on their GitHub has published an alternative bootloader and RRF 3.2 binaries for MKS Robin Nano V3, can we expect that this board will be supported by TeamGloomy Configurator and more recent RRF versions?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gloomyandy/RepRapFirmware/issues/100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATUSBSDXOAMP4SAOBRJLSDT6ZCEDANCNFSM5C3NUINA .

KosVas91 commented 3 years ago

I do not understand a lot in programming, so my next question most likely will be naive and silly. Comparing the source code that MKS has published with 3.2_4 build from this GitHub shows that MKS code has only 9 modified files (just few lines difference in each) and 1 new file MKS_ROBIN.h. Do these changes need to be figured out?

diff

Lino77 commented 3 years ago

if it helps, these are the changes I made to get it to work with me, and the bootloader, of course MKS_Nano.zip

gloomyandy commented 3 years ago

@Lino77 I'm curious as to why you had to disable DMA support for SPI3. What was the problem. I'm not aware of any issues with using SPI3/DMA in other situations.

KosVas91 commented 2 years ago

@gloomyandy I have tested @Lino77 version and it working fine. May be, you could compile the latest version of RRF (v3.3.0_9+) with NANO v3 PINS/BoardConfig and your vision of correct SPI3/DMA configuration? I will be happy to test it. It would be really great to get support of NANO v3 by this project, because a NANO v1.2 was/is extremely popular board in Chinese printers and NANO v3 is great drop-in replacement for it.

jaysuk commented 2 years ago

I'm pretty sure we won't be supporting this board due to the changes that are required will require a separate build.

On Tue, 21 Sept 2021 at 08:33, KosVas91 @.***> wrote:

@gloomyandy https://github.com/gloomyandy I have tested @Lino77 https://github.com/Lino77 version and it working fine. May be, you could compile the latest version of RRF (v3.3.0_9+) with NANO v3 PINS/BoardConfig and your vision of correct SPI3/DMA configuration? I will be happy to test it. It would be really great to get support of NANO v3 by this project, because a NANO v1.2 was/is extremely popular board in Chinese printers and NANO v3 is great drop-in replacement for it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gloomyandy/RepRapFirmware/issues/100#issuecomment-923717155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATUSBVHP7DX44EBV3ASCMTUDAYLJANCNFSM5C3NUINA .

Lino77 commented 2 years ago

@KosVas91 i build it but untetstet 3.3.0_9_mks_nano.zip