search

gloomyandy / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
257 stars 61 forks source link

Included <exception> std header #117

Closed stephen-opet closed 2 years ago

stephen-opet commented 2 years ago

The header is required to compile v3.3 on Debian Linux, or an error gets thrown on the call to 'std::terminate_handler', line 296 (now 297).

Admittedly not necessary if the package is built on Gloomy's recommended stack. But the rest of the build runs rather smoothly on debian, and the header is quite small to include

gloomyandy commented 2 years ago

Looks like we have this include in later versions of the code, are you building 3.3 for LPC support or is there some other reason?

stephen-opet commented 2 years ago

The introduction of CANlib in v3.4 presented greater compatibility issues when building on debian than v3.3. Reverting was the path of least resistance.

Didn't dig too deep into v3.4 - if you've already included exception in subsequent releases, I suppose this conversation is moot. Thanks!

jaysuk commented 2 years ago

I need to update the build instructions to cover the combined F4 and H7 builds.

On Tue, 19 Jul 2022, 18:07 Stephen Opet III, @.***> wrote:

The introduction of CANlib in v3.4 presented greater compatibility issues when building on debian than v3.3. Reverting was the path of least resistance.

Didn't dig too deep into v3.4 - if you've already included in subsequent releases, I suppose this conversation is moot. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/gloomyandy/RepRapFirmware/pull/117#issuecomment-1189342738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATUSBRBM3V2FDZYZS7XWZ3VU3OELANCNFSM535SZQMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>