Should be impossible to overwrite files in transfer

glormph / kantele

Lab proteomics raw and search data management

2 stars 1 forks source link

Should be impossible to overwrite files in transfer #57

Closed glormph closed 3 months ago

glormph commented 9 months ago

Need to do some kind of check on overwrites, because now it's happened once that a user errored in copy paste and got the wrong filenames out of the instrument which were then overwritten to the tmp share. We can then rename and restore the old file from backup, but it's inconvenient and would be much better if this were somehow impossible.

Error on file with identical name present in the system.

glormph commented 6 months ago

Make impossible:

[ ] upload file with same name (check at upload of file)
[ ] rename file to existing name
[ ] rename file to existing dir (storage_loc)
[ ] move file to location

"copy analysis output" cannot overwrite since analysis are saved using an ID and a timestamp in the dirname.

If relevant, address this issue in a PR with #37