search

glos / myglos

Repository for MyGLOS (GLOS Data Portal)
GNU General Public License v3.0
2 stars 2 forks source link

Boaters' missing units toggle #243

Closed kkoch closed 6 years ago

kkoch commented 6 years ago

User Thomas Martin (email: tmartin8025@gmail.com) noticed that we don't have the Set Units toggle in the hamburger menu like on the Portal. He would like to change from metric to english units.

Is this an easy implementation over to Boaters'?

Bobfrat commented 6 years ago

@kkoch we have this enabled in Dev. It should work for all the models and station data but i don't believe we'll convert any of the marina metadata. Are there any marina attributes that need to be converted? If it looks good can we push to production?

kkoch commented 6 years ago

@Bobfrat I think you are correct - I can't think any of the marina data that would include a unit needing conversion, so I think we are good.

(As a side note, I'm still waiting on the clean marina details from SeaGrant before I have an updated csv for you on those.)

kkoch commented 6 years ago

@Bobfrat status on the push to production? (as noted above, we can do so assuming it doesn't muck with marinas at this point).

Bobfrat commented 6 years ago

@kkoch the version on dev has been pushed to production. Note there was about 5 minutes of downtime as I deployed.

kkoch commented 6 years ago

Works (doubt anyone noticed on the downtime - but if so, we can at least know the reason).