search

glosis-ld / glosis

GLOSIS ontology network
Other
11 stars 7 forks source link

problem in layer horizon with PH #65

Closed rapw3k closed 2 years ago

rapw3k commented 2 years ago

We have two classes for the same observation: http://w3id.org/glosis/model/layerhorizon#PH http://w3id.org/glosis/model/layerhorizon#pH

the difference is that observedProperty http://w3id.org/glosis/model/layerhorizon#PH http://www.w3.org/ns/sosa/observedProperty value http://w3id.org/glosis/model/layerhorizon#pHProperty

http://w3id.org/glosis/model/layerhorizon#pH http://www.w3.org/ns/sosa/observedProperty value http://w3id.org/glosis/model/codelists#physioChemicalPropertyCode-pH

the name should be http://w3id.org/glosis/model/layerhorizon#PH but i cant remember which one should be the correct observedProperty, is it the code list value or the individual value?

rapw3k commented 2 years ago

@ldesousa please check this

rapw3k commented 2 years ago

I noticed also the difference is in the result, and we have another duplicate

http://w3id.org/glosis/model/layerhorizon#PH http://www.w3.org/ns/sosa/hasResult only http://w3id.org/glosis/model/layerhorizon#PHValue where PHValue is subclass of http://w3id.org/glosis/model/layerhorizon#PhysioChemicalValue

http://w3id.org/glosis/model/layerhorizon#pH http://www.w3.org/ns/sosa/hasResult only http://w3id.org/glosis/model/layerhorizon#pHValue pHvalue is not subclass of http://w3id.org/glosis/model/layerhorizon#PhysioChemicalValue

also I think correct name should be PHValue, but please confirm

rapw3k commented 2 years ago

i think for consistency the observed property should be http://w3id.org/glosis/model/codelists#physioChemicalPropertyCode-pH but please tell me what you think

ldesousa commented 2 years ago

Definitly http://w3id.org/glosis/model/codelists#physioChemicalPropertyCode-pH should be the observed property. To remain consistent with the other physio-chemical properties.

The following instances need to be removed:

These are currently in lines 1670 to 1685.

And these two instances remain:

rapw3k commented 2 years ago

Probably reverse due to the case convention. I mean it should stay: http://w3id.org/glosis/model/layerhorizon#PHValue http://w3id.org/glosis/model/layerhorizon#PH

remove: http://w3id.org/glosis/model/layerhorizon#pH http://w3id.org/glosis/model/layerhorizon#pHValue http://w3id.org/glosis/model/layerhorizon#pHProperty

change http://w3id.org/glosis/model/layerhorizon#PH to have observed property http://w3id.org/glosis/model/codelists#physioChemicalPropertyCode-pH

what do you think?

Montanaz0r commented 2 years ago

hey @rapw3k @rapw3k please take a look at: https://github.com/rapw3k/glosis/pull/66

I think this solves this issue

ldesousa commented 2 years ago

@rapw3k I propose you accept #66 and then apply the last changes you suggest (having only glosis_lh:PH and glosis_lh:PHValue). I agree the case convention should be consistent (all capitals).

ldesousa commented 2 years ago

Closed via #66