Adding concept set - Githubissues

glossarist / glossarist-ruby

Concept modeller in Ruby

BSD 2-Clause "Simplified" License

1 stars 1 forks source link

Adding concept set #50

Closed HassanAkbar closed 1 year ago

HassanAkbar commented 1 year ago

Added class Glossarist::ConceptSet which contains
- concepts -> Glossarist::ManagedConceptCollection object
- bibliographies -> BibliographyCollection object
- assets -> Collections::AssetCollection object
Created class BibliographyCollection which inherits from Relaton::Db and implements methods to fetch the sources of all concepts.
Created class Asset which will contain details related to a single asset

closes #49

HassanAkbar commented 1 year ago

@ronaldtse The test cases are failing because of a bug in relaton 1.11.1 which was fixed in relaton 1.12 and that only support ruby version greater then 2.6.

What should we do here? should we also drop support for ruby less than 2.6 in glossarist?

ronaldtse commented 1 year ago

should we also drop support for ruby less than 2.6 in glossarist?

Yes please, we can drop Ruby 2.5. Thanks.

HassanAkbar commented 1 year ago

Ping @ronaldtse