search

glossarist / iev-data

1 stars 1 forks source link

Retry on Relaton errors #103

Closed skalee closed 3 years ago

skalee commented 3 years ago

Relaton often raises network errors. Retrying few times is a good idea. Fixes #102.

ronaldtse commented 3 years ago

@skalee do you think this should be handled in Relaton as user expectation?

cc @andrew2net @opoudjis

skalee commented 3 years ago

Maybe, but I don't know Relaton good enough to have strong opinion on that.

I can help to implement automatic retries on network errors in Relaton if needed.

ronaldtse commented 3 years ago

@skalee got it, I believe @andrew2net could implement that -- some sites have rate limiting and also limitations on parallel access which can be tricky to apply across flavors, so @andrew2net would be in the best position to do so. Will make a new issue.

ronaldtse commented 3 years ago

@skalee please feel free to merge this first and then when Relaton gets it implemented we can update. Thanks!

skalee commented 3 years ago

Yes, in fact it may be due to throttling or rate limiting. Good catch. Anyway, I'm merging right now.

skalee commented 3 years ago

Perhaps #111 will help more.