glossarist / iev-data

1 stars 1 forks source link

Localized item’s `entry_status` is “Standard” #115

Closed strogonoff closed 3 years ago

strogonoff commented 3 years ago

While migrating IEV data to register glossary format, I noticed that items have entry_status: Standard.

Our registry schema uses the following statuses, in accordance with ISO 19135-1 (see 6.2 and 7.5.2):

const ITEM_STATUSES = [
  'submitted',
  'valid',
  'superseded',
  'retired',
  'invalid',
] as const;

Example:

pol:
  id: 904-03-14
  terms:
  - type: expression
    normative_status: preferred
    usage_info: systemu
    designation: tryb czuwania
    gender: m
    plurality: singular
  - type: expression
    designation: tryb nieaktywny
    gender: m
    plurality: singular
  language_code: pol
  notes: []
  examples: []
  entry_status: Standard
  review_decision_event: published

(cc @ronaldtse)

strogonoff commented 3 years ago

If entry_status: Standard maps to register item status valid, we can map that value at the “Glossarist Desktop YAML -> Glossarist registry YAML” conversion stage.

skalee commented 3 years ago

@ronaldtse Could you clarify on this one? Looks like every row in the spreadsheet has "Standard" in the STATUS column. There are no other values, I've checked that already.

ronaldtse commented 3 years ago

Yes. Entry status “standard” maps to “valid”. In “Status” we only see the value “Standard” because the IEV export we are given only contains published content — behind there are other status values — I suspect they include the “in-process” and retired statuses. The full database is probably twice as large.

skalee commented 3 years ago

@strogonoff I can make another release if you want it fixed right now.

skalee commented 3 years ago

If entry_status: Standard maps to register item status valid, we can map that value at the “Glossarist Desktop YAML -> Glossarist registry YAML” conversion stage.

I guess I can simply replace "standard" with "valid" in our export tool, unless @ronaldtse says we need to keep "standard" in these YAMLs.

ronaldtse commented 3 years ago

I guess I can simply replace "standard" with "valid" in our export tool

This is totally fine with me 👍 We just need to document this somewhere so we know the status mapping.

skalee commented 3 years ago

I'm not familiar with Glossarist internals so I'll do whatever you guys prefer. Fixing it in the export tool is trivial.

ronaldtse commented 3 years ago

@skalee right, can we have this change done so @strogonoff can prepare for his demo this Friday? Thanks!

skalee commented 3 years ago

@ronaldtse Pull request created. I will make a new release when I merge it.

skalee commented 3 years ago

@strogonoff v0.23.20201217 released in this repo. Soon concepts.zip will be generated by GHA.

ronaldtse commented 3 years ago

Thanks @skalee !

strogonoff commented 3 years ago

@strogonoff v0.23.20201217 released in this repo. Soon concepts.zip will be generated by GHA.

Awesome, thank you!