search

glossarist / iev-data

1 stars 1 forks source link

Delete dead logic from ConceptCollection #184

Closed skalee closed 3 years ago

skalee commented 3 years ago

These two methods were used to serialize whole concepts collection and write it to one huge YAML, but this is no longer the case.

ronaldtse commented 3 years ago

I believe @strogonoff still uses the single file concepts for conversion into Paneron. We should instead update the export mechanism to meet the Paneron format. Can you please check with him?

skalee commented 3 years ago

I doubt. I've removed this feature many weeks ago. These two methods are nothing but leftovers.

single file concepts

To be clear: this is about "all concepts in one file" feature, not about "every concept in separate file" feature.

ronaldtse commented 3 years ago

We last ran the import many weeks ago...

To be clear: this is about "all concepts in one file" feature, not about "every concept in separate file" feature.

Yes, I was talking about "all concepts in single file".

Anyway feel free to merge this, since we will need to reimplement that part anyway.

ronaldtse commented 3 years ago

And ping on #185 ...

skalee commented 3 years ago

It has been deleted in #98 in January. We had releases since then (e.g. we've added links to superseded concepts).