Open skalee opened 3 years ago
@HassanAkbar can you help address this issue? Thanks!
@ronaldtse What should we do in this case? There is no column in the sheet for classification and currently, the classification value is obtained from the SYNONYM1STATUS
column which is also used for the normative_status
value.
Also currently there is no other value except Standard
in the STATUS
column and it is used for the entry_status
value.
@HassanAkbar the full dataset (that contains historic information) will have other values in the STATUS
column. Is the point to make these status values configurable per dataset?
@ronaldtse There are actually 2 points
classification
and currently, the classification
value is obtained from the SYNONYM1STATUS
column which is also used for the normative_status
value. According to skalee this seems like a bug or this might cause bugs in the future because the classification
is for overall concept while SYNONYM1STATUS
is for synonym 1. Standard
in the STATUS
column and it is used for the entry_status
value. (You have answered this question in the last comment)
Following pseudo YAML illustrates the problem, only relevant fields included:
(Only relevant fields are included. Of course some spreadsheet columns may contain more than one designation, but let's skip that for simplicity.)
What I want to say is that localized concept's
classification
andnormative_status
for the 2nd term are taken from the same SYNONYM1STATUS column, and that smells like a bug. There is no TERMSTATUS column or anything like that in the spreadsheet. There is STATUS column, but it always says "Standard" and is used forentry_status
:https://github.com/glossarist/iev-data/blob/22a7561c76593673aa35f23987e10f4e4db440b8/lib/iev/termbase/term_builder.rb#L370-L375
cc @ronaldtse