glossarist / iev-data

1 stars 1 forks source link

Refactor how designations are built #193

Closed skalee closed 3 years ago

skalee commented 3 years ago

NestedTermBuilder class was only making things complicated. Its two use cases, i.e. building symbol and expression designations, were only illusorily similar. In both cases a hash was produced, but its content was almost entirely different.

This pull request simplifies things by replacing the problematic NestedTermBuilder class with two simple topic methods. Additionally, some repeated logic is moved to these methods rather than being evaluated outside of them.

Making this change greatly simplifies upgrading Glossarist dependency to higher versions.