glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Add Ignored Files Generated From Boxen #14

Closed braidn closed 8 years ago

braidn commented 8 years ago

Gitignore update

braidn commented 8 years ago

Just a few tweaks to the gitignore for boxen related files.

thisiscab commented 8 years ago

Good catch! Totally forgot about Boxen :)

braidn commented 8 years ago

Yeah not going to call out for a CR but will keep open for a bit to allow anyone to air grievances

DanielWright commented 8 years ago

The only "grievance" I can think of is the absence of motivation for a Node runtime or PhantomJS environment (or dotenv, for that matter). But updating the gitignore seems too fine a hair to split on these matters.

braidn commented 8 years ago

PRECISELY! And with this there is a permanent blocker unless you add them in yourself.

DanielWright commented 8 years ago

Didn't think about it that way. Genius! 🎉