search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Fix Some Effects of a Wonky Merge #38

Closed DanielWright closed 7 years ago

DanielWright commented 7 years ago

Because the gem is within the Solidus ecosystem, but the implementation is still namespaced within Spree, some (moderately confusing) separation of concerns took place, and caused some wonky merges. This PR proposes to resolve those bad merges:

  1. While lib/solidus_retail.rb is the entrypoint for the gem, the engine definition is within spree/retail/engine.rb to match the expected Spree::Retail module namespace.
  2. Dotenv wheedled its way back into the gem.
thisiscab commented 7 years ago

👍