search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Better express the dependency on spree_product_asssembly #44

Open thisiscab opened 7 years ago

thisiscab commented 7 years ago

A major problem right now is that the way we are using the assembly gem in our fork is different of the original implementation.

Instead of a product having parts (which is the case in our fork), variants have parts (in the original implementation). We'll have to figure something out.

This solves https://github.com/glossier/solidus_retail/issues/37

thisiscab commented 7 years ago

The problem I had expressed:

Instead of a product having parts (which is the case in our fork), variants have parts (in the original implementation). We'll have to figure something out.

Was not true. I just had made a dummy mistake :)

braidn commented 7 years ago

@cabouffard did you ping anyone here for a Code review?

thisiscab commented 7 years ago

Ping @braidn @DanielWright @bryanmtl Here is part of the argument: https://github.com/glossier/solidus_retail/issues/37