glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Should the GeneratePosOrder service object be refactored? #55

Open DanielWright opened 7 years ago

DanielWright commented 7 years ago

The GeneratePosOrder service object is a dense and complex object. It relies on a lot of things going right to work correctly, and doesn't recover from failures very gracefully. It's also tightly coupled to how orders are processed, and thus can be painful to integrate. Finally, it's murderous to test.