search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Use the first option value presentation as the variant title #60

Closed thisiscab closed 7 years ago

thisiscab commented 7 years ago

In Shopify we were representing the variant title with the following string price: 10$ for a gift card

Now it will only show: 10$

DanielWright commented 7 years ago

What do you think of introducing a presenter here, to less tightly couple the Shopify product title to the Spree model layer? Or d'you think it's overkill at this point?

thisiscab commented 7 years ago

@DanielWright 💃

The presenter part of it was already existing and the converter already gets the presented_object and not the object itself. I had just forgotten that we have had that logic laying around.

The change was quite trivial to do, thanks for the reminder! 🗡