search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Separate the refund import process in multiple objects #61

Closed thisiscab closed 7 years ago

thisiscab commented 7 years ago

I've been toying around, trying to figure out a better way to structure the code surrounding the Shopify refund importer.

The code is not namespaced correctly but this should give a general idea on how I was thinking about stuff.

thisiscab commented 7 years ago

Hey! If you guys are down to give me comments or ideas or anything, that would be great.

It's not yet functional but it should give a good idea of what I'm aiming for. Also those classes are so small that it should easier to tests in contrary of what's currently there.

thisiscab commented 7 years ago

@mickeyren Hey, I'd like to get this merged into master, would you mind doing a quick CR please?

papayaah commented 7 years ago

@cabouffard nothing sinister looking out of the blue - but then again not sure if i'm the right person to look into reviewing this. how about @bryanmtl eyes?

thisiscab commented 7 years ago

In my mind, if the specs still passes, it means that it will still work has expected. I think we are good to go 🗡

thisiscab commented 7 years ago

@bryanmtl May want to hold off though, since he's currently testing.