search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Add the proper tax adjustments on refund #78

Closed thisiscab closed 7 years ago

thisiscab commented 7 years ago

It seems like that when you create a refund on Solidus, it removes all the adjustments associated with an order.

The adjustments is what contained the taxes, so by removing the adjustments, the order decreases prices and thus we refund the client with a lower amount of money than they actually paid.

thisiscab commented 7 years ago

This will fix https://github.com/glossier/glossier-v2/issues/1676

I've created specs to validate this in the gem and I've tested it locally with glossier-v2 and it also works. I'd like to have your review, thanks!

thisiscab commented 7 years ago

You kidding me, how come we're getting tons of rubocop errors now? ergghhh

thisiscab commented 7 years ago

I initially wrongly though that the adjustments were getting removed when we were creating a refund, but this was due to the fact that my local environment was not properly set-up.