search

glossier / solidus_retail

Solidus Extension to Support Retail Operations
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Namespace Updater Classes #83

Closed braidn closed 7 years ago

braidn commented 7 years ago

The Retail gem has some pretty aggressive namespacing going on. Due to this (I believe), that when updating bundled products on Shopify, the BundledProductExporter won't be firing within the Retail namespace. This will cause the update to fail and halt the entire request/response lifecycle.

braidn commented 7 years ago

@dvassev this is a SUPER small change but, I wanted to show it off due to it being a problem when we update existing sets in the admin. If a request/response updated a set, BundledProductUpdater would always fail because it wouldn't be able to figure out its' namespace.

dvassev commented 7 years ago

Very interesting, will keep in mind for the future.

dvassev commented 7 years ago

Wait, don't we want to merge this into admin-warehouse-skus and not master?