search

glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🧰👌 Use ruff for formatting (replaces black, isort and nbqa) #1396

Closed s-weigand closed 10 months ago

s-weigand commented 10 months ago

This change replaces black, isort and nbqa with ruff. We need to run ruff 3 times (still faster than running the other tools!) because the import sorting is part of the linter and not the formatted (different rust crates) so they don't know about each others rules.

Change summary

Checklist

github-actions[bot] commented 10 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/use-ruff-format

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d5d44e) 84.5% compared to head (015d0d3) 84.6%.

Files Patch % Lines
...lotaran/deprecation/modules/examples/sequential.py 0.0% 1 Missing :warning:
glotaran/project/result.py 85.7% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1396 +/- ## ======================================= Coverage 84.5% 84.6% ======================================= Files 91 91 Lines 3664 3691 +27 Branches 722 722 ======================================= + Hits 3098 3124 +26 - Misses 451 452 +1 Partials 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.