glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

Fix linked clp result creation #1418

Closed joernweissenborn closed 8 months ago

joernweissenborn commented 8 months ago

This fixes the issue that CLP in linked data not the same because they were calculated individually in the result creation.

github-actions[bot] commented 8 months ago

Binder :point_left: Launch a binder notebook on branch joernweissenborn/pyglotaran/staging-0.8

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (662d2d5) 84.6% compared to head (3deb5c6) 84.9%. Report is 1 commits behind head on staging.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1418 +/- ## ========================================= + Coverage 84.6% 84.9% +0.3% ========================================= Files 91 91 Lines 3691 3746 +55 Branches 722 728 +6 ========================================= + Hits 3124 3182 +58 + Misses 452 450 -2 + Partials 115 114 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jsnel commented 8 months ago

Not to future self (@jsnel ) - as suggested by the bots in this PR, review in greater detail all .copy operations (at a later time).