Closed jsnel closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
065ee43
) 84.9% compared to head (3c4b3d2
) 84.9%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Verified the changes work
The optimizer would crash
When setting the values in the model scheme from a constant to a parameter, the optimizer would crash with "Cannot determine Numba type of <class 'glotaran.parameter.parameter.Parameter'> " as it tried to use the parameter as a numeric value. Ultimately numba would complain as that's where the value would be first used.
Specifically:
"glotaran\builtin\elements\kinetic\matrix.py", line 27
Note: This PR doesn't add a unit test (yet), but that should be added at the level of the optimizer since the element tests themselves work only with numeric definitions.