search

glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🧹 Remove redundant backsweep flag from GaussianActivationParameters #1423

Closed s-weigand closed 9 months ago

s-weigand commented 9 months ago

Just a small additional clean-up after #1422 to get rid of the backsweep boolean flag, which is a residual of the < 0.8 model syntax when we had this as user input.

Change summary

Checklist

github-actions[bot] commented 9 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/remove-redundant-backsweep-flag

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5f16090) 84.9% compared to head (438a7e9) 84.9%.

Files Patch % Lines
glotaran/builtin/elements/kinetic/matrix.py 0.0% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1423 +/- ## ========================================= - Coverage 84.9% 84.9% -0.1% ========================================= Files 91 91 Lines 3746 3744 -2 Branches 728 728 ========================================= - Hits 3182 3180 -2 Misses 450 450 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.