search

glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🧹 Use element plugin registry to define LibraryType #1427

Closed s-weigand closed 7 months ago

s-weigand commented 7 months ago

By using the plugin registry instead of looking up inheritance we can ensure that only elements that were explicitly added are valid types (e.g. ExtendableElement is not instantiable by itself and should not be part of LibraryType).

Change summary

Checklist

github-actions[bot] commented 7 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/use-element-registry

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (491a7b6) 84.9% compared to head (0834cf1) 84.9%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1427 +/- ## ========================================= - Coverage 84.9% 84.9% -0.1% ========================================= Files 91 91 Lines 3744 3742 -2 Branches 728 728 ========================================= - Hits 3180 3178 -2 Misses 450 450 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.