glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

✨ Add official Python 3.12 support #1437

Closed s-weigand closed 6 months ago

s-weigand commented 6 months ago

Numba 0.59.0 added python 3.12 support, which means so can we.

Change summary

Checklist

github-actions[bot] commented 6 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/py312-support

github-actions[bot] commented 6 months ago

Benchmark is done. Checkout the benchmark result page. Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.2 vs. main ``` All benchmarks: | Change | Before [1fb14bbc] | After [cbf1ba78] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-----------------------------------------| | | 239M | 241M | 1.01 | IntegrationTwoDatasets.peakmem_optimize | | | 1.33±0.03s | 1.29±0.08s | 0.97 | IntegrationTwoDatasets.time_optimize | ```
Benchmark diff main vs. PR ``` All benchmarks: | Change | Before [cbf1ba78] | After [f2a402ef] | Ratio | Benchmark (Parameter) | |----------|----------------------|---------------------|---------|-----------------------------------------| | | 241M | 239M | 0.99 | IntegrationTwoDatasets.peakmem_optimize | | | 1.29±0.08s | 1.27±0.02s | 0.98 | IntegrationTwoDatasets.time_optimize | ```
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.6%. Comparing base (2c88dce) to head (f2a402e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1437 +/- ## ===================================== Coverage 88.6% 88.6% ===================================== Files 107 107 Lines 5128 5133 +5 Branches 962 965 +3 ===================================== + Hits 4544 4549 +5 Misses 468 468 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud