glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

⬆️ Combined updates #1458

Closed s-weigand closed 3 months ago

s-weigand commented 3 months ago

Besides combining dependabot up PRs, this PR also changes pydantic from v1 to v2 and fixes a deprecation sharing when calling groupby on xarray data structures due to a changed default.

Change summary

Checklist

Closes issues

closes #1460 closes #1457 closes #1456 closes #1454 closes #1453 closes #1451 closes #1449 closes #1448 closes #1444 closes #1443 closes #1442

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/combined-updates

github-actions[bot] commented 3 months ago

Benchmark is done. Checkout the benchmark result page. Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.2 vs. main ``` All benchmarks: | Change | Before [1fb14bbc] | After [d1cd0bc0] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-----------------------------------------| | | 239M | 239M | 1 | IntegrationTwoDatasets.peakmem_optimize | | | 1.51±0.05s | 1.50±0.08s | 0.99 | IntegrationTwoDatasets.time_optimize | ```
Benchmark diff main vs. PR ``` All benchmarks: | Change | Before [d1cd0bc0] | After [9ea5f448] | Ratio | Benchmark (Parameter) | |----------|----------------------|---------------------|---------|-----------------------------------------| | | 239M | 239M | 1 | IntegrationTwoDatasets.peakmem_optimize | | | 1.50±0.08s | 1.44±0.06s | 0.96 | IntegrationTwoDatasets.time_optimize | ```
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.6%. Comparing base (2c88dce) to head (9ea5f44). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1458 +/- ## ===================================== Coverage 88.6% 88.6% ===================================== Files 107 107 Lines 5128 5133 +5 Branches 962 965 +3 ===================================== + Hits 4544 4549 +5 Misses 468 468 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud